elplatt / seltzer

CRM for hackerspaces
GNU General Public License v3.0
104 stars 51 forks source link

incompatability with PHP 8.* - DO NOT UPGRADE #507

Closed chris18890 closed 1 year ago

chris18890 commented 1 year ago

Due to some syntax changes in PHP 8 seltzer will not load at all, the user is greeted with a blank screen, most of these have been found & remediated in #506

Even after this merge, clean installs of seltzer are broken due to the use of the variable module/table to store config information which seems to create an infinite loop situation: PHP complains about not being able to read from the variable table... because it doesn't exist, & it doesn't exist because install.php hasn't been run yet, but it can't be run because the page won't load as it can't read from the variable table...

I've tested various combinations of this:

The crux of it seems to be the get_variable() function in seltzer/crm/modules/variable/variable.inc.php