incompatability with PHP 8.*

elplatt / seltzer

CRM for hackerspaces

GNU General Public License v3.0

104 stars 51 forks source link

incompatability with PHP 8.* #527

Closed chris18890 closed 9 months ago

chris18890 commented 11 months ago

Alongside #506 & #511, due to changes in PHP from 7.4 > 8.*, reports & paypal contacts are causing errors

getting a "cannot access offset of type string on string" error when trying to access paypal contacts
getting a "argument must be of type array string given" error when trying to access reports

happy for any/all help on this one @drid @ramgarden!

joshprittse commented 11 months ago

That offset error might be related to how the paypal CSV file/export file has a UTF-8 character (BOM?) at the end that needs to be shaved off.

chris18890 commented 11 months ago

Unfortunately I don't think so, cause the Paypal CSV relates to the payments, this is related to the paypal contacts, which are created when creating a new member.

I've tested importing members from CSV & also creating a new single member, both result in the same error, so I think it's how paypal_contact_data is getting emails, and/or how paypal_contact_table is displaying them

drid commented 10 months ago

Report fail because of argument order See https://www.php.net/manual/en/function.implode.php

drid commented 10 months ago

See https://github.com/elplatt/seltzer/pull/532/commits/aeea0ada440fd0e63c44f67d7ffbe2c9be3c4c5c I am not sure this is the proper approach