nvidia-x11-drv: Install systemd unit file for nvidia-persistenced on EL7 and EL8

elrepo / packages

Kernel module (driver) packages to improve RHEL's hardware support

https://elrepo.org/

83 stars 49 forks source link

nvidia-x11-drv: Install systemd unit file for nvidia-persistenced on EL7 and EL8 #251

Closed jthiltges closed 2 years ago

jthiltges commented 2 years ago

Notes:

The RPMs build OK with centos+epel-7-x86_64 and centos-stream+epel-8-x86_64 but I haven't yet tested further
Legacy drivers are not yet updated
Changelog and release numbers are not yet updated

If this looks like a change that could be considered for merging, I'd be happy to work on updating the legacy drivers specs as well.

pjperry commented 2 years ago

I don't see any rush to update for legacy releases as upstream releases are few and far between, plus we've just missed the RHEL 8.7 rebuilds. My only concern is the BR on systemd-rpm-macros, which comes from EPEL, which is not enabled by default on our RHEL build system. Can you expand on that - is it to support the %pre %post scriptlets?

jthiltges commented 2 years ago

I appreciate the feedback, thank you.

I was following the Fedora systemd scriptlet docs. Seems it's fine on EL8, with systemd providing systemd-rpm-macros. You're quite right that it's an issue for EL7. I'll update the EL7 BR to systemd.

pjperry commented 2 years ago

Thanks, looks good so I've merged ready for the next upstream release (or required rebuild). I note on rhel8 that there is no systemd-rpm-macros package but it is provided by the systemd package. As the docs recommends a BR for systemd-rpm-macros, I'm happy with that.

pjperry commented 1 year ago

Upstream have released v515.86.01, which has just been built and pushed to our mirror sites and contains this commit. Packages should be available on our mirror sites shortly. Thanks again for the contribution