search

elrnv / autodiff

Auto differentiation library
Apache License 2.0
63 stars 7 forks source link

`to_radians` and `to_degrees` methods cause loss of the derivative #2

Closed paveloom closed 1 year ago

paveloom commented 1 year ago

Current implementation:

https://github.com/elrnv/autodiff/blob/a5d46e680ffcaf0b9eba891de7bdbe4fdbe24e10/src/forward_autodiff.rs#L1279-L1286

Seems like changing it to proper implementations should be straightforward:

elrnv commented 1 year ago

I absolutely agree thanks for the catch!