Open solkaz opened 3 years ago
@solkaz I'm still trying to figure out how would that work, when I started this the it was very small and I didn't think much about the license at the time.
The biggest problem I have is that some icons that are being submitted are alterations of existing work, which could in itself be a licensing nightmare. So I've been thinking about taking them off all from GitHub for now until I have that figured out, and in the future I might build an API.
I would like to know more about this as well since I do want to put it in my personal dotfiles repo. Perhaps making sure that when users upload icons they had to agree to release the icons in GPL.
I noticed the Algolia API works well! Would it be worth publishing behind a proxy with your keys there instead of plain text?
@texastoland Yeah, Algolia works amazingly well and surprisingly easy to work with. I've set the keys to work as environmental variables, so that gives it some level of protection. I can't put the search on the backend as that would massively increase the number of requests (now it's almost getting 5M requests per month). But I might eventually migrate to Nuxt and run the search function on the middleware which runs on the server.
I was able to inspect them in the request headers on the site. Just want you to be aware if there's any risk. I was checking the API because it'd be a nice feature for Unite SSB (not my app).
I can see that this project uses the GNU General Public License v3.0. What is unclear to me is whether the icons themselves (that were uploaded to this project) also fall under the GPL license. This would help maintainers of other projects understand whether they are allowed to use those icons and under what conditions (example issue in d12frosted/homebrew-emacs-plus).