When looking at DBWorkManager.go as part of #213 I realized that in this call:
numDirs, err := w.walkDB(tFirst, tLast, walkFunc)
the returned err is neither checked nor logged, which could lead to unexpected behavior if e.g. reading a directory fails or something like that (because it will just output less data, silently skipping over the error).
This has to be fixed as part of #213 (because I need to return / handle a specific error in that path) but I'm raising this issue so we don't forget it in case we decide to forego / skip said issue and for some reason the PR doesn't make it into main.
When looking at
DBWorkManager.goas part of #213 I realized that in this call:the returned
erris neither checked nor logged, which could lead to unexpected behavior if e.g. reading a directory fails or something like that (because it will just output less data, silently skipping over the error).This has to be fixed as part of #213 (because I need to return / handle a specific error in that path) but I'm raising this issue so we don't forget it in case we decide to forego / skip said issue and for some reason the PR doesn't make it into
main.