elsa-workflows / elsa-core

A .NET workflows library
https://v3.elsaworkflows.io/
MIT License
6.42k stars 1.19k forks source link

Elsa.FileStorage should be using a Framework Reference instead of a deprecated package #5107

Closed thompson-tomo closed 7 months ago

thompson-tomo commented 7 months ago

The Elsa.FileStorage package has a package reference for Microsoft.AspNetCore.Http however that package is deprecated and instead a framework reference should be being used as is the case in Elsa.SasTokens

glime-ai[bot] commented 7 months ago

To address the issue with the Elsa.FileStorage package referencing the deprecated Microsoft.AspNetCore.Http package, you should consider submitting a pull request to the Elsa GitHub repository if you are comfortable doing so. This would involve updating the project file for Elsa.FileStorage to use a FrameworkReference to Microsoft.AspNetCore.App instead of the package reference to Microsoft.AspNetCore.Http.

If you are not comfortable with submitting a pull request or if you prefer the maintainers to handle it, you can open an issue on the Elsa GitHub repository explaining the situation. Provide details about the deprecated package and suggest using a FrameworkReference as done in Elsa.SasTokens. The maintainers of the repository can then take the necessary steps to update the package.

Here is an example of how the FrameworkReference should look in the .csproj file:

<ItemGroup>
  <FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>

This change would align Elsa.FileStorage with the current best practices for referencing ASP.NET Core framework components.