search

elsaland / elsa

❄️ Elsa is a minimal runtime for JavaScript and TypeScript written in Go
MIT License
2.79k stars 61 forks source link

Fix some code quality issues and add code transformer #109

Closed siddhant-deepsource closed 3 years ago

siddhant-deepsource commented 3 years ago

Fixes #85

This pull request fixes some of the issues raised by DeepSource on my fork of this repo.

Some issues were automatically fixed by DeepSource, while I fixed some of them by hand.

This PR also contains a .deepsource.toml, in case you want to run continuous quality analyses on your repository. If you wish to do so, you can follow these steps:

Adding to reporting the code quality issues, I have also added the Go (gofmt) and JavaScript (Prettier) Transformers which support auto-formatting of code on every new pull-request. You can find the transformers docs here.

If you don't want to use DeepSource, I can edit the PR to remove the .deepsource.toml file.

littledivy commented 3 years ago

Deepsource looks really nice - I'll sign up asap

siddhant-deepsource commented 3 years ago

Hey @littledivy 👋 Just following up, in order to activate DeepSource on this repository, you can follow these steps :

Thanks and a Happy New Year 🙂

littledivy commented 3 years ago

@siddhant-deepsource sorry for being super late on this, I've signed up for deepsource. Can you rerun the CI via an empty commit so it can be merged?

siddhant-deepsource commented 3 years ago

@littledivy Done. Please review the PR. Thanks :)

Also, thanks a lot for signing up for DeepSource 🎉 We'll try to make sure you have a great experience using it.

Thanks :)