search

elsampsa / valkka-core

Valkka - Create video surveillance, management and analysis programs with PyQt
GNU Lesser General Public License v3.0
181 stars 35 forks source link

docker/run.bash parameter misused #64

Open RKAnonymous opened 1 month ago

RKAnonymous commented 1 month ago

General Question

I cloned the repo and executed commands one-by-one as it was written in readme file.

Linux: Ubuntu 20.04

  1. create_image.bash x86_ubuntu_20 local_1.0.0 x86_ubuntu_20 for Ubuntu version as it was indicated. 1.0.0 for my local valkka image.

But problem comes here. When I run run.bash x86_ubuntu_20 (Why I put x86_ubuntu_20? Because there was written [TAG] in all places and I thought it should be the same as the previous command)

And it raises error: Unable to find image 'valkka:x86_ubuntu_20' locally docker: Error response from daemon: pull access denied for valkka, repository does not exist or may require 'docker login': denied: requested access to the resource is denied. See 'docker run --help'.

What I realized here is run.bash script is using [TAG] parameter as valkka image tag ...-it valkka:$1 /bin/bash, but not a ubuntu image tag. I suggest, in the 4th step [TAG] parameter somehow should differ from the ones used in other commands. For example: [VALKKA_TAG], if $2 parameter was provided in the 3th step.

I did not check the case that $2 is empty though.

Thank you.

RKAnonymous commented 1 month ago

Hi.

This is my workaround.

...
### Create Image
./create_image.bash [OS_TAG] [IMAGE_TAG]

### Install the libValkka
./run.bash [IMAGE_TAG]
...