shadow - Githubissues

elsassph / createjs-def

CreateJS Toolkit definitions generator

http://philippe.elsass.me/2013/05/type-annotations-for-the-createjs-toolkit/

58 stars 20 forks source link

shadow #1

Closed FabianPP closed 11 years ago

FabianPP commented 11 years ago

Hi,

your script is exactly what I was looking for. I appreciate all that work. I found 2 bug:

"shadow: Shadow;" should be written as "shadow: createjs.Shadow;"
"shadow: Shadow;" gets written multiple times into the classes

elsassph commented 11 years ago

Apologies, I didn't update the toolkit for a while and they must have changed the generated JS. I can't promise when I'll be able to check that.

elsassph commented 11 years ago

Actually the problem was a lot easier to fix: code generation didn't change, it's just a bug.

All drop-shadows and glows are simulated using createjs.Shadow class, but generated code didn't properly reference it as createjs.Shadow which is now fixed on github. I pushed the update on npm but I'm not sure how fast it's taken into account...