search

elsassph / hxtsdgen

TypeScript declaration file generator for Haxe JavaScript output target
65 stars 12 forks source link

flag for cast to any not rendered types #17

Open francescoagati opened 5 years ago

francescoagati commented 5 years ago

hi, in some case (enum abstract) hxtsdgen block the output process with this error. i think that should be better launch a warning but without block the process and cast to any. or have a flag for don't throw an exception and only a warning and cast the unknown type to any

https://github.com/nadako/hxtsdgen/blob/bfb4062eb6ab519e8091aded83fcdea123fcf792/src/hxtsdgen/TypeRenderer.hx#L85

elsassph commented 5 years ago

What branch are you testing? Is that master or branch feature/6_include-related in PR?

elsassph commented 5 years ago

But I agree a warning would be better

francescoagati commented 5 years ago

master

elsassph commented 5 years ago

Please try the branch if you don't mind

cancerberoSgx commented 5 years ago

Is there a PR for this ? If fixed please could you update haxelib repo ? I currently need to comment that line - just a warning is enough here since probably will take some time to support all clases... Should I PR ? Maybe a flag as argument / macro to throw. (by default should not) Thanks, nice project!

elsassph commented 5 years ago

You're right, it shouldn't throw but print a warning. Please PR if you can.