elschilling / sunposition

Sun position 3D viewer
sunposition.vercel.app
GNU General Public License v3.0
49 stars 11 forks source link

Sun position issue #2

Open blotfi opened 2 years ago

blotfi commented 2 years ago

Hi again I noticed that if I keep the same hour and change the month over the year, the sun position change from one eight to an other eight, which is impossible. I think there is an error in the algo. Best regards, Lotfi

elschilling commented 1 year ago

Hi @blotfi thanks for reporting! I couldn't reproduce the issue here, when I change the month it stays within the same analemma as it should. Could you please give more information of the steps you are doing? Thanks

itsme-Alex commented 1 year ago

Hi ! I may be wrong but it looks like your live app has the issue he's describing. When you only change the month, the sun goes to the previous analemma and comes back in month 10

edit : ok so i think i found his issue. Maybe it's due to the fact that he's looking for a location that have daylight saving hour, so you have to adjust the timezone accordingly

blotfi commented 1 year ago

there is also an issue if I stop animating time and change only the day of the month when it goes from 29 to 30 the sun pos glitches (jumps) I noticed it on February, march and October so (bissextile ? and DST changing date also I think)