elsevier-research / wercker-aws-ecs

5 stars 24 forks source link

run.sh: Reduce dependency footprint #7

Closed TomFrost closed 9 years ago

TomFrost commented 9 years ago

Note: this takes the place of PR #6 -- a duplicate, but from the wrong branch

When deploying a Docker container, it's common to choose a very minimal base image such as one based on alpine, and not only are many of the commands used in run.sh not installed by default in that image, some of them aren't available in the package manager.

This PR:

Now, if alpine is being used as the base box, adding this script step in the deploy pipeline will allow this step to run:

- script:
    name: install ecs deployment deps
    code: |
      apk update
      apk add python openssl sudo

Note: theoretically sudo could be removed as well, but since it's very small and available in alpine's package manager, I didn't feel it necessary.

nhuray commented 9 years ago

Thanks @TomFrost for this PR. Seems good to me so I will merge it soon.