elsiklab / gccontent

A JBrowse plugin for plotting GC content and GC skew
5 stars 2 forks source link

display is off by one #4

Closed childers closed 7 years ago

childers commented 7 years ago

The display has an off-by-one issue, which isn't really obvious unless the windowsize and windowdelta are set to 1. Below is a screenshot with a BigWig GC track "GC Content" and below that the GCContent plugin based of the sequenceChunk.

  "maxExportSpan": 500000,
  "autoscale": "global",
  "logScaleOption": false,
  "style": {
    "height": 31,
    "pos_color": "#0000ff",
    "neg_color": "#ffff00",
    "bg_color": "rgba(230,230,230,1)",
    "clip_marker_color": "black"
  },
  "min_score": 0,
  "max_score": 1,
  "windowSize": 1,
  "windowDelta": 1,
  "gcMode": "content",
  "bicolor_pivot": 0.5,
  "scoreType": "avgScore",
  "storeClass": "JBrowse/Store/SeqFeature/SequenceChunks",
  "urlTemplate": "seq/{refseq_dirpath}/{refseq}-",
  "label": "GCContent",
  "type": "GCContent/View/Track/GCContent",
screen shot 2017-07-06 at 4 26 49 pm
cmdcolin commented 7 years ago

Added a potential fix on master, feel free to try out :)

childers commented 7 years ago

This looks like it fixed the off-by-one issue. Thanks!

screen shot 2017-07-10 at 1 13 49 pm