search

elsoul / skeet

🚀 Open-Source TypeScript Serverless Framework. It supports all kinds of application development, from small-scale tasks to global full-stack scaling💃
https://skeet.dev/
Apache License 2.0
599 stars 20 forks source link

Fail to create new project #414

Open dyaskur opened 4 months ago

dyaskur commented 4 months ago

I tried to run skeet new and return below error:

skeet new
? Enter the name of the app skeet-app
🚛 Downloading base template...📦 ⠼node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: ENOENT: no such file or directory, open 'skeet-app/package.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'skeet-app/package.json'
}

Node.js v20.11.1

My OS is macOS Sonoma m1

POPPIN-FUMI commented 4 months ago

Which version are you using? I tried it, and it works with the latest version!

skeet -V
2.2.23
dyaskur commented 4 months ago

I used skeet latest version also. Previously I have pnpm problem, but fixed by :

mkdir -p ~/.pnpm/store
export PNPM_HOME=~/.pnpm/store
pnpm setup
source ~/.zshrc

I got that command from https://github.com/pnpm/pnpm/issues/5883#issuecomment-1444057690

does it related to my current problem?

dyaskur commented 4 months ago

After debugging this repository, I've discovered that the issue stems from wget not being installed on my computer. It's puzzling why the process continues despite the download failure. Additionally, considering that macOS and windows comes with curl pre-installed and most Linux distributions also have it readily available, it raises the question: why are we using wget instead of curl?

I'm planning to submit a pull request to switch to CURL and include error messages for download failures. There are various reasons downloads can fail, such as missing curl/wget, blocked URLs, URL not found, or connectivity issues. Would that be alright?

Furthermore, I've noticed numerous inconsistencies in variable names and some code duplications. If permissible, I'd like to undertake a refactoring effort to address these issues as well.

POPPIN-FUMI commented 4 months ago

Hello,

Thank you for the report! I've also reviewed your pull request and appreciate the excellent work.

We have a Discord chat where we discuss our open-source software projects, and I'd like to invite you to join us there. Here's the link: Discord Chat.

I'm planning to integrate Vitest into this repository. Given that we're transitioning from Skeet v2 to v3, a significant amount of refactoring is necessary. It would be great to discuss this further on our Discord thread.

Thank you very much for your contributions!