elstoc / ecms-ui

ecms (ui)
1 stars 0 forks source link

Improve page title handling #123

Open elstoc opened 3 months ago

elstoc commented 3 months ago

Page title is set based on a useEffect hook that will only fire if the props of a component change. However, if a sub-component attempts to override the title of a higher-level component, and is then unmounted, the higher-level useEffect won't necessarily re-fire and update the title to its previous value.

elstoc commented 1 month ago

Perhaps a global context with the page title is the best way to do it