search

eltiare / carrierwave-vips

CarrierWave image processing powered by VIPS
MIT License
91 stars 39 forks source link

swap cache position #1

Closed jcupitt closed 12 years ago

jcupitt commented 12 years ago

I think putting the cache earlier should give a speedup. I'd like to benchmark before suggesting you merge, but I can't see how to get carrierwave-vips-benchmark to use my fork of carrierwave-vips, unfortunately.

jcupitt commented 12 years ago

OK, all done now I think. I've updated the carrierwave-vips-benchmark README, it seems to all be working with these changes:

https://github.com/stanislaw/carrierwave-vips-benchmarks

Thank you very much for making this into a proper gem and fixing my ruby.

eltiare commented 12 years ago

I'll review the changes get this into the gem.

stanislaw commented 12 years ago

Any updates on this?

I am going to write Carrierwave guys about carrierwave-vips as a good alternative to default RMagick. What I want, is at least to have an outline about carrierwave-vips in their wiki.

Thanks.

eltiare commented 12 years ago

It's done.

jcupitt commented 12 years ago

Thank you Jeremy. Sorry the patch was so messy, I didn't realise my later cmmits would be added to the pull request.

On Thursday, 2 August 2012, Jeremy Nicoll wrote:

It's done.

Reply to this email directly or view it on GitHub: https://github.com/eltiare/carrierwave-vips/pull/1#issuecomment-7443301