eltiare / carrierwave-vips

CarrierWave image processing powered by VIPS
MIT License
92 stars 39 forks source link

RMagic dependency #20

Closed y8 closed 7 years ago

y8 commented 9 years ago

Hi.

Why is carrierwave-vips depends on RMagic? If this is not necessary, could you please remove it from gemspec?

Thanks

eltiare commented 9 years ago

It's a dependency of vips, so it is a dependency of carrierwave-vips. If you wish to continue this conversation I'd suggest opening a ticket on that repo.

y8 commented 9 years ago

Um, sorry but RMagick can't possibly be a vips library dependency since RMagick a ruby fronted for ImageMagick and GraphicMagick. It has nothing to do with vips, because vips is not a ruby library.

Also, you are using ruby-vips interface, and it's their responsibility to maintain dependencies. But anyway, there no RMagick dependency in ruby-vips, and you can use it without building Rmagick.

y8 commented 9 years ago

References:

Library's ImageMagick/GraphicMagic optional dependencies:

eltiare commented 9 years ago

Oh, you're right. Sorry about that - been a while since I've dug into the internals of all of this. One of the perils of having something work for a long time. I'll look into it, I think it had something to do with loading GIF files. Perhaps I'll strip out the requirement and then add a note to the README that to load the gif files rmagick is required.

tonytonyjan commented 9 years ago

FYI https://github.com/eltiare/carrierwave-vips/pull/21

eltiare commented 7 years ago

Fixed in master.