eltiare / carrierwave-vips

CarrierWave image processing powered by VIPS
MIT License
92 stars 39 forks source link

Update ruby vips and carrierwave. #27

Closed skunkworker closed 6 years ago

skunkworker commented 6 years ago

This updates ruby-vips & carrierwave to the newer versions. It also has fixes for setting the exif data more explicitly, to be inline with the newer ruby-vips api.

eltiare commented 6 years ago

Does the old API still work with the newer library?

skunkworker commented 6 years ago

Everything worked except for setting the exif data. image.set('exif-Orientation', '') but being more explicit about the type that was being set allowed it to work successfully. image.set_type GObject::GSTR_TYPE, 'exif-Orientation', ''

skunkworker commented 6 years ago

I will also update the .travis.yml

eltiare commented 6 years ago

I'd prefer to keep the dependencies' versions as low as possible for backwards compatibility. You never know when requiring an update in someone's project will break things. I'll play with this over the next week to find out what those minimum versions are, if you're not able to tackle that.

raimondasv commented 6 years ago

@eltiare any chances this could be released as a new gem version?

eltiare commented 6 years ago

@raimondasv My only concern is updating Carrierwave to the latest version. Does this need to happen? Has the API changed? I haven't been using Ruby as much as I used to, and haven't had the time to check on this stuff.

raimondasv commented 6 years ago

https://github.com/jcupitt/ruby-vips#older-versions

Ruby-Vips API changed a bit. With this, ruby-vips 1.0 won't work

Cannot comment much on carrierwave version, gem is locked at >= 0.11 which, I guess, is ok.

eltiare commented 6 years ago

I will merge the changes and release a new version. If someone freaks out about the carrierwave being too old then we'll change it. :)

eltiare commented 6 years ago

I've upgraded ruby-vips and pushed a new gem version.

raimondasv commented 6 years ago

@eltiare thank you!