search

eltiare / carrierwave-vips

CarrierWave image processing powered by VIPS
MIT License
92 stars 39 forks source link

Allow configuration of allowed file formats #33

Closed ohrite closed 4 years ago

ohrite commented 4 years ago

Hi there @eltiare!

First, thanks for your super useful gem. We've got an additional use case, which is that we're creating webp versions, which aren't currently allowed in CarrierWave::Vips#convert . We've added an additional field to the configuration struct called allowed_formats, which allows folks to customize this list as needed.

We've added test coverage to CarrierWave::Vips#convert exercising this change.

Do you have any changes or suggestions?

eltiare commented 4 years ago

This looks good. I'll merge once you remove the draft hold.