search

eltoroit / ETCopyData

SFDX Plugin to populate your scratch org and/or developer sandbox with data extracted from multiple sObjects.
113 stars 23 forks source link

Exit Code Zero even if there is an ETCopyData Failure #22

Closed homerlex closed 5 years ago

homerlex commented 5 years ago

FYI - I posted the same question in the Saleforce DX Chatter group

I found that the exit code from sfdx is sometimes zero even if there was a failure. I'm using the ETCopyData plugin and I can't be sure if the problem is with the plugin or with sfdx itself. What I know is that in version 6.52.2 of sfdx-cli I get an exit code of "1" when there is an error in ETCopyData. With sfdx-cli 7.14 I get an exit code of zero. Any thoughts?

OscarScholten commented 5 years ago

I also noticed that ETCopyData does not always return a non-zero exit code when it should. I've created a fix in the following commit that should find its way to master in this repo soon:

https://github.com/OscarScholten/ETCopyData/commit/274e1bc0b1911f9d05d4fbf8b01ed43d982cc0ce

eltoroit commented 5 years ago

@OscarScholten so that's what that error means? :-) Do you want to create a pull request?

eltoroit commented 5 years ago

@OscarScholten did your pull request fix this?

OscarScholten commented 5 years ago

No, I will do another pull request for this coming Monday

Sent from my iPhone

On 6 Oct 2019, at 05:22, Andres Perez notifications@github.com wrote:

@OscarScholten did your pull request fix this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

eltoroit commented 5 years ago

Thanks, @OscarScholten, I made some changes yesterday and closed a few issues which were opened for a while. Once you do this new pull request, I will update the npm package.