search

eltos / SimpleDialogFragments

An Android library to create dialogs with ease and handle user interaction reliably, using fragments and material design.
Apache License 2.0
119 stars 17 forks source link

SimpleDialogFragments show showHsvWheel problem with low res device #23

Closed sf99 closed 6 years ago

sf99 commented 6 years ago

Steps to reproduce

  1. Show dialog showHsvWheel on low res device Landscape mode 720*580

Expected and actual behaviour

Expected full dialog window - get not full color picker window, some parts missed, transparent and hex are not fully visible and usable. The window should be wider.

Test Environment

Property Value
Screen resolution 580x720
Screen density
Library version
Android version 4.2
eltos commented 6 years ago

In order to reproduce this, not only the screen resolution is required, but - and more importantly - the screen density (dpi value or category). What library version are you using? And can you please provide a screenshot showing what you mean?

sf99 commented 6 years ago

Hi, thanks you for your quick response.

I am looking for nice and useful color picker for android devices ( small or large ) and yours looks well.

I am trying to implement it with my app. It looks OK in portrait mode, but in landscape mode it looks different with different devices and different resolutions - not only small densities as I have found.

I am sending you screenshots from emulators:

Nexus 4 , api 17 - portrait mode - OK, the same Nexus 4 api 17 landscape mode - problem

Pixel C api 26 landscape mode - problem

I am testing it also with some real devices and also with your SimpleDialogFragments app. and it looks very different and not complete in landscape mode for different devices/resolutions.

Best Regards

Slavomir

P.S. It would be perfect to use new google libraries lv. 26 if it is possible.

On Sun, Jan 28, 2018 at 5:46 PM, Philipp Niedermayer < notifications@github.com> wrote:

In order to reproduce this, not only the screen resolution is required, but - and more importantly - the screen density (dpi value or category). And can you please provide a screenshot showing what you mean?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eltos/SimpleDialogFragments/issues/23#issuecomment-361076773, or mute the thread https://github.com/notifications/unsubscribe-auth/AGtGcxLLgVKeyj4wo3Zl5bCCAz0OlZylks5tPKRzgaJpZM4RvOx9 .

eltos commented 6 years ago

Sorry to bother you with the same question again, but what screen densities do these devices have???

I have been testing it with the following configuration – and it works perfectly, both in portrait and landscape mode:

Property Value
Screen Resolution 2560×1440
Screen denity 576 dpi
Test app version 2.2.1
Android version 7.0 (API 24)

Also, where did you send these screenshots?

Here is mine: screenshot_20180129-103252

sf99 commented 6 years ago

Nexus 4 768x1280 (~318 density)

Pixel C 2560x1800 (~318 density)

"Also, where did you send these screenshots? " I am not sure, I understand well, I have sent them only to your mail.

Next screenshot is from my real device - tablet Lenovo A5500-F Android 4.4.2 800 x 1280 pixels, 16:10 ratio (~189 ppi density) and SimpleDialogfragments app. Landscape

Slavomir

On Mon, Jan 29, 2018 at 10:48 AM, Philipp Niedermayer < notifications@github.com> wrote:

Sorry to bother you with the same question again, but what screen densities do these devices have???

I have been testing it with the following configuration – and it works perfectly, both in portrait and landscape mode: Property Value Screen Resolution 2560×1440 Screen denity 576 dpi Test app version 2.2.1 Android version 7.0 (API 24)

Also, where did you send these screenshots?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eltos/SimpleDialogFragments/issues/23#issuecomment-361192277, or mute the thread https://github.com/notifications/unsubscribe-auth/AGtGcyLbYuukcyegrOctjxeZe7jGNAcuks5tPZPbgaJpZM4RvOx9 .

eltos commented 6 years ago

I see, you commented via an email reply. I don't think attachments are supported because I never received any. You can upload them to your comments by editing when using the webinterface.

sf99 commented 6 years ago

OK I understand, screen_landscape1 screen_landscape2 screenshot_2018-01-29-12-07-48

sf99 commented 6 years ago

It looks like simpledialogfragment_color_wheel layout land is OK, I have test it separate as simple activity layout. The problem is using it with dialog.

eltos commented 6 years ago

So I ended up reworking the layout using ConstraintLayout (See the constraintLayout-Branche). I tested it on these devices in portrait and landscape mode without any issues:

Can you please confirm that the issue is solved with #24 so I can merge it?

eltos commented 6 years ago

Published in v2.2.2