search

eltos / SimpleDialogFragments

An Android library to create dialogs with ease and handle user interaction reliably, using fragments and material design.
Apache License 2.0
119 stars 17 forks source link

Make automatic opening of Spinner when focusing optional #45

Closed mtotschnig closed 5 years ago

mtotschnig commented 5 years ago

If the first form field in a SimpleFormDialog is a spinner, it automatically opens when the dialog is displayed. I think this is irritating at least in that circumstance. I am not sure if this has some benefit in other circumstances.

eltos commented 5 years ago

That's a future, not a bug.

The intention is to save the user from unnecessary clicks. It's for the same reason, that input fields are automatically focused and the keyboard is shown and one can use IME actions to go to the next field of the form etc.

eltos commented 5 years ago

If you have a different opinion on this, I think we can add an option to disable this behaviour. Have a look at SimpleFormDialog.java#L237.

mtotschnig commented 5 years ago

I understand the rationale, and I think it makes sense when navigating to the next field. That it is at least problematic on the first field, is demonstrated also after orientation change. Then the spinner is opened again even if user already has selected a value. But in general, when the dialog opens, I prefer to give the user a complete view of the form, which is hidden by the open spinner. As a consequence, I'd appreciate the option you suggest.