Closed eltos closed 1 year ago
Shouldn't the argument default to false? For me, I am not sure if this adds value to this library, Given the requirement of a screen that should always appear fullscreen, I would probably not use a dialog fragment, but a standard fragment, or an activity.
I meant that .fullscreen()
is equivalent to .fullscreen(true)
, of course the default without that call is a standard pop up dialog.
@mtotschnig So you don't think the simple API of this library and it's features like the form dialog would make using it preferable over designing and implementing a new fragment or activity from scratch?
So you don't think the simple API of this library and it's features like the form dialog would make using it preferable over designing and implementing a new fragment or activity from scratch?
It probably depends on the use case. I think the simple API has its advantages for simple dialogs that I would want to render as a dialogue not full-screen. The advantage of using an activity is that the data can be passed in a type-safe way with Androidx Activity Result Contracts.
From the Material3 Design Guide:
Proposed method signatures
Links