elucent / Albedo

Graphics and effects library for Minecraft modding. Does not fear hax!
MIT License
22 stars 6 forks source link

GL memory leak #8

Open mcfilmmakers opened 6 years ago

mcfilmmakers commented 6 years ago

Albedo has a GL memory leak issue. I can't pin down EXACTLY what is causing it but the best I can manage is that Albedo creates GL leak when Forge has difficulty loading things.

I can easily reproduce the issue when Albedo is paired with ANY mod that REQUIRES a dependency but the dependency is missing.

For example, If I have Albedo running alongside Angel of Vengeance (which requires TamModized) it runs fine, remove TamModized and Albedo causes a memory leak. Removing Albedo does not produce the memory leak even if TamModized is also missing.

Another example: If I have Albedo running alongside Actually Baubles (which requires Actually Additions AND Baubles) it runs fine, remove either or both Actually Additions or Baubles and Albedo causes a memory leak. Removing Albedo does not produce the memory leak even if Actually Additions and/or Baubles is also missing.

See here for log: https://pastebin.com/v0pVJKkU

NOTE: This is not the only cause of the memory leak. The memory leak also happens when Forge has texture errors (sometimes) or can't load other aspects of other mods but I can't test these scenarios to find a common cause.

mcfilmmakers commented 6 years ago

So its been over two weeks. I can confirm the issue persists in the latest version of Albedo.

My further testing has narrowed down the cause to a specific combination: Albedo and hammercore 1.9.4.8.

Removing either one stops the GL Error. I don't know why these two aren't playing nice but there you have it. Tested in 1.12.1 and 1.12.2

pastebin: https://pastebin.com/EGNUn78y

chadmcn commented 6 years ago

Having the same issue with a modpack I am working on. I had figured out that taking out hammer core fixed it but only temporarily and albedo did not work at all either.