search

elucent / GravelOres

Simple gravel ores for 1.11.2
2 stars 4 forks source link

Crash when I:orePileChance=0 #11

Closed OrdinatorStouff closed 6 years ago

OrdinatorStouff commented 6 years ago

1.12 gravelores-1.7b.jar

When setting I:orePileChance=0 and creating a new world, client crashes. Console log says something about "value must be positive."

If you need more details let me know

OrdinatorStouff commented 6 years ago

crash-2017-08-06_18.33.21-server.txt

KnightMiner commented 6 years ago

Ya, don't do that. I really need to make a release where I prevent all the possibly of crashes from the config.

I assume you were trying to disable oregen while still having the ores? Right now its supported to just backlist all the ores, but I'll add a more proper way to do it in the future.

OrdinatorStouff commented 6 years ago

Okay that's fair and for now I just turned everything down to 1 but in my defense it's specifically instructed in the config comments to set to 0 to disable:

    # Chance per chunk that an ore pile will spawn. Set this to zero to disable generation. [range: 0 ~ 32767, default: 20]
    I:orePileChance=1
KnightMiner commented 6 years ago

Huh, must be an oversight. The code never had a specific case for it being 0, so its on my TODO list to fix.

KnightMiner commented 6 years ago

Fixed in version 1.8, which is now on CurseForge