elucent / GravelOres

Simple gravel ores for 1.11.2
2 stars 4 forks source link

Digging noise sounds like stone, gravel spawns on ice #2

Closed kragnoth closed 7 years ago

kragnoth commented 7 years ago

As title. Version 1.1, minecraft verison 1.11.2

The digging noise for the gravel ores is the pickaxe sound for stone.

Gravel is spawning on ice as well. Maybe only have it spawn on ice if the ice is two thick (i.e. glaciers?)

elucent commented 7 years ago

I'll fix the digging sound. Ice never spawns two thick naturally so in a vanilla environment it would basically be disabling gravel ore spawning, so it basically comes down to: would you rather have it spawn on ice or not?

kragnoth commented 7 years ago

hmmm... I guess it isn't a huge issue, so I'd just fix the digging sound.

Is it possible to make the all in one tool count as a shovel for the gravel ores without needing to do anything super special on your side?

elucent commented 7 years ago

Hmmm...it should be something handled in the class for the AIOT. I'll ask Ellpeck about it -- my gravel ores aren't using anything other than the simple vanilla setHarvestLevel() function, so I'm guessing it's something he'd want to support on his side.

kragnoth commented 7 years ago

there is a config option in AA to add it manually, so I'm not sure if you really need to worry about it.

Might I make a suggestion? Maybe make a config to make the gravel ores only spawn on certain block types that the user enters (by default its everything), I just came across an astral sorcery temple with gravel ore on top of it :D

ChloeDawn commented 7 years ago

*bump* Pleaseeeee fix the gravel sound, it's been bugging me for months now :v

elucent commented 7 years ago

Will be fixed in the 1.12 ver.