elucent / eidolon

Spooky Minecraft mod.
Other
30 stars 27 forks source link

[Question][1.16.5] Heat Sources #114

Open drakray opened 2 years ago

drakray commented 2 years ago

I see in the code these as Heat Source: MAGMA_BLOCK FIRE SOUL_FIRE LAVA CAMPFIRE.LIT SOUL_CAMPFIRE.LIT

Is there a way to configure more source? Either by Config or blockTags? I'd like some modded source to count, like SoulFire from Druidcraft, SpiritFire from Occultism, Campfires from OhTheBiomesYoullGo and EndergeticExpansion, and FirePlace from Vampirism

Something like blockTag:forge:heat_source would make that easily configurable with CraftTweaker, for example, and make modder able to implement it by default if they want

Alexthw46 commented 2 years ago

About campfires, the solution can be easily achived replacing the vanilla check with a generic (instance of CampfireBlock && [isLit] ).

I added that line in Hexblades update, but having a tag here in Eidolon would be easier and more compatible.

drakray commented 2 years ago

Yeah, I think Elucent should make the Crucible use blockTags, something like forge:heat_source, it would make it MUCH easier to adapt in mods and modPack using CraftTweaker

EDIT: I just realized we are ALREADY on Eidolon's issue tracker, not Hexblades lol XD Crossed wires XD