Calculating scales with nOctUp != 0 causes issues

elucideye / acf

Aggregated Channel Feature object detection in C++ and OpenGL ES 2.0 based on https://github.com/pdollar/toolbox

BSD 3-Clause "New" or "Revised" License

49 stars 20 forks source link

Calculating scales with nOctUp != 0 causes issues #67

Closed JN-Jones closed 6 years ago

JN-Jones commented 6 years ago

Similar to #62: If nOctUp is not 0 the scaling doesn't work. This is caused by double s = std::pow(2.0, -double(i) / double(nPerOct + nOctUp)); which adds nOctUp to nPerOct before the division while the matlab code does scales = 2.^(-(0:nScales-1)/nPerOct+nOctUp); which adds it after the divion. Simple fix would be to cast both variables seperatly: double s = std::pow(2.0, -double(i) / double(nPerOct) + double(nOctUp));

headupinclouds commented 6 years ago

Thanks again. I'll send a fix shortly.

headupinclouds commented 6 years ago

Applied in https://github.com/elucideye/acf/pull/68 (testing) and updated contributors

headupinclouds commented 6 years ago

Merged.