search

elucideye / drishti

Real time eye tracking for embedded and mobile devices.
BSD 3-Clause "New" or "Revised" License
392 stars 82 forks source link

hunter-packages Foo/Foo.h could conflict with local src/3rdparty/Foo/Foo.h #367

Closed headupinclouds closed 7 years ago

headupinclouds commented 7 years ago 
src/3rdparty//ARM_NEON_2_x86_SSE/CMakeLists.txt:  "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>"
src/3rdparty//boost-pba/CMakeLists.txt:  "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>"
src/3rdparty//imshow/CMakeLists.txt:  "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>"
src/3rdparty//ogles_gpgpu/ogles_gpgpu/CMakeLists.txt:    ogles_gpgpu PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/..>"
src/3rdparty//sse2neon/CMakeLists.txt:  "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>"
src/3rdparty//thread-pool-cpp/CMakeLists.txt:  "$<BUILD_INTERFACE:${THREAD_POOL_CPP_INC_DIR}>"

As long as nothing includes the top src/3rdparty directory it should be okay. I checked existing BUILD_INTERFACE use and these are all pointing at least one level down. I see no global include for the 3rdparty folder either.

I had a suspicion this was violated in at least one place and wanted to leave a note to check it. Closing for now.

ruslo commented 7 years ago

Need to check that all the local includes came before all the external 3rd party. Need to take a look at BEFORE/AFTER, imported targets add a mess here too.