elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x
Apache License 2.0
116 stars 55 forks source link

Regenerate .cs from .x and format #305

Closed leighmcculloch closed 3 years ago

leighmcculloch commented 3 years ago

What

Regenerate the .cs files from the current .x files in the repo, and run dotnet-format.

Why

When I follow this process with the latest xdrgen available here it results in diffs adding the using System; to the beginning of all files. According to @elucidsoft in https://github.com/elucidsoft/dotnet-stellar-sdk/issues/302#issuecomment-764820020 the using System; should be kept. It might have been lost in the past, or maybe somebodies IDE removed them automatically.

Making this change keeps the .cs files generated from the .x files consistent with what xdrgen (along with a dotnet-format) generates which makes it easier for others to regenerate the .cs files, since there are not extra diffs.

Types of changes