search

elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x
Apache License 2.0
116 stars 55 forks source link

Change trust operation "limit" field optional #316

Closed l3utterfly closed 3 years ago

l3utterfly commented 3 years ago

According to stellar docs, the "limit" field should be optional for the change trust operation.

https://developers.stellar.org/docs/issuing-assets/how-to-issue-an-asset/

image

Kirbyrawr commented 3 years ago

Thanks for the report, i will take care of it soon!

Kirbyrawr commented 3 years ago

I was checking a bit how they do in the official SDK's of Stellar, in case the limit field is omitted they just get the maximum value of int64, so i will do something similar here. In case of official Java SDK however they don't even have the no limit option.

What im trying to say is that the limit wont stop dissapear it will just default the value to the maximum int64 value.

Kirbyrawr commented 3 years ago

Here is the PR with the change. https://github.com/elucidsoft/dotnet-stellar-sdk/pull/317

elucidsoft commented 3 years ago

Resolved in Release 7.1.3