Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses and refactorization of operation responses tests.

elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x

Apache License 2.0

116 stars 55 forks source link

Muxed Account fields in OperationsResponses, EffectResponses and TransactionResponses and refactorization of operation responses tests. #321

Closed Kirbyrawr closed 3 years ago

Kirbyrawr commented 3 years ago

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] I have read the CONTRIBUTING document.
[X] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

fracek commented 3 years ago

What happens if the response does not contain a _muxed_id field? I think the field should become a nullable long to handle this case. I would also keep the old test files and add the new version (with muxed ids) to make sure we don't break backward compatibility.

Kirbyrawr commented 3 years ago

On it