elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x
Apache License 2.0
116 stars 55 forks source link

SEP-10: apply grace period to minTime constraint #331

Closed JakeUrban closed 1 year ago

JakeUrban commented 2 years ago

SEP-10: Apply grace period to minTime constraint

It is possible that the client machine's clock is behind the SEP-10 server machine's clock.

If this is the case, client applications calling readChallengeTx() may not be able to validate the challenge due to the challenge transaction's minimum timebound being greater than the client machine's current time.

Changes

readChallengeTx() or the equivalent function

Implementations

Both the JS and Go SDKs have been updated with these changes.

JakeUrban commented 2 years ago

https://github.com/stellar/stellar-protocol/issues/1057

elucidsoft commented 1 year ago

Merged