Potential error for missing Retry-After header

elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x

Apache License 2.0

117 stars 54 forks source link

Potential error for missing Retry-After header #362

Closed vinamogit closed 1 year ago

vinamogit commented 2 years ago

https://github.com/elucidsoft/dotnet-stellar-sdk/blob/5ff3242c8be03c7c679ec125c6ac9544e6e0e1bb/stellar-dotnet-sdk/requests/ResponseHandler.cs#L17

The Retry-After header is not guaranteed to be sent by the horizon instance, this leads to an unexpected exception in Java implementation, reporting on dotnet for verification.

See stellar/java-stellar-sdk#433

elucidsoft commented 2 years ago

I would guess this needs to be changed to FirstOrDefault if that is the case to prevent the exception.

Kirbyrawr commented 2 years ago

@elucidsoft can you do that please?

elucidsoft commented 2 years ago

Yes, will get a commit for this shortly.