Issues when attempting to create Muxed Accounts - Githubissues

elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x

Apache License 2.0

117 stars 55 forks source link

Issues when attempting to create Muxed Accounts #364

Closed ArcosChris closed 2 years ago

ArcosChris commented 2 years ago

I hope this is the best place to find answers to this issue. I have attempted many times to create muxed accounts using this SDK, but I continue to have this problem where any Muxed accounts that are created do not get created in stellar or become associated with the base account (G… Address). So once I make a muxed account and try to look for it in stellar expert or stellar lab, it won't come up, or it comes up with a different base account address. I also tried to do this with the JS SDK for testing purposes, and it works as intended. However, I am just lost, and I do not want to keep trying if I do it incorrectly. So please help me find a solution to this problem. Thank you. Please see the images below, which might explain this better.

Also, I am newer to working with Stellar so if I am going about this the wrong way I would really appreciate any pointers. I tried looking everywhere for answers but cant seem to find any documentation on creating the Muxed Account with dotnet-stellar-sdk.

---JS Attempt JSAttempt

-- dotnet Issues

Kirbyrawr commented 2 years ago

Hi, it seems like this is a bug, i'm researching it but i suspect where it comes from, will write more when i have more information, thanks for the report.

Kirbyrawr commented 2 years ago

Hi, this is fixed in https://github.com/elucidsoft/dotnet-stellar-sdk/pull/366, thanks for the report.

Kirbyrawr commented 2 years ago

imagen

ArcosChris commented 2 years ago

@Kirbyrawr Thank you so much. I really appreciate the work you guys do! I am new to a lot of things and wanted to know how long it takes for changes to be implemented in package? Or is there another I can start using your changes?

Kirbyrawr commented 2 years ago

Hi, i need to check the tests failing, but thats not a biggie, when the PR is reviewed and merged @elucidsoft will upload the Nuget, usually it doesnt take a lot of time, if you need to use it quickly you can also download the repo and use it outside of nuget but i recommend to wait. Give it a day or two maximum

Kirbyrawr commented 2 years ago

Hi, tests are fixed now, it seems the decode was also bugged, i fixed both things and now it works with the XDR data, i will let @elucidsoft know.

It gives me the proper laboratory results as in your report. and i updated the tests with the new data.

Kirbyrawr commented 2 years ago

Sorry, it seems another test was failing, somehow my IDE wasn't running them properly. It seems now its all fixed (hopefully) and the PR can be reviewed.

ArcosChris commented 2 years ago

@Kirbyrawr no problem! thank you again

Kirbyrawr commented 2 years ago

@elucidsoft can you please take a look into the PR? Thanks!

ArcosChris commented 2 years ago

@Kirbyrawr is this just waiting on approval?

Kirbyrawr commented 2 years ago

Yeah, sadly @elucidsoft is having a lot of real life complications and he needs to focus on them. I don't know how we can handle this, maybe i can merge it directly.

ArcosChris commented 2 years ago

Oh man, no problem! I hope everything gets better.

elucidsoft commented 2 years ago

Thanks @Kirbyrawr and @ArcosChris for being patient while I deal with some stuff in my life. I am going to merge this now.

ArcosChris commented 2 years ago

@elucidsoft @Kirbyrawr Thank you both very much for your help with this.