Missing price_r from OfferResponse

[HarvieKrumpet]

OfferResponse can only parse "Price" which is not enough precision for Price Has this: [JsonProperty(PropertyName = "price")] public string Price { get; private set; }

What it needs is this: [JsonProperty(PropertyName = "price_r")] public Price PriceR { get; private set; }

Without it, you don't pull in the numerator/denominator and the price will be off...

[elucidsoft]

Can you do a PR for this change?

[HarvieKrumpet]

You just need to add those two lines. You can leave the "price" property as-is. But "price" will always be wrong. I don't even know why it exists. "price_r" is the correct way, and follows the same pattern as all the rest of the operations that deal nominator/denominator. I am not really setup to be cloning/pushing to github here.

[elucidsoft]

@HarvieKrumpet Not ignoring, was moving and handling some personal stuff. I will get to this soon.

[elucidsoft]

The merge for this is coming, waiting for the .NET 6 Branch to get committed and this will be included.

[Abduljlil]

() ؛

[Abduljlil]

() ؛@Abduljlil

[Abduljlil]

() ؛@Heteroculturalism