Alphanumeric assets are more specifically typed.

[GuyWhoKnowsTheGuy]

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ X ] Breaking change (fix or feature that would cause existing functionality to change)
• [ X ] I have read the CONTRIBUTING document.
• [ X ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ X ] I have added tests to cover my changes.
• [ X ] All new and existing tests passed.

These changes introduce a breaking change for the sake of (1) fixing a design flaw and (2) adding convenience when accessing an asset's code or issuer. The biggest issue, imho, is the fact that CreateNonNativeAsset orders the "Code" parameter before the "Issuer" parameter. The overloaded method that was removed, and likely used out in the field, orders the "Issuer" parameter before the "Code" parameter. If one simply removes the "AssetType" parameter, they will get runtime errors. However, if they have any unit tests with alphanum assets, it will be caught each and every time, since the an issuer is always more than 12 characters long. All in all, I believe this breaking change does far more good than harm, and will almost certainly be caught on first test/debug run.

[elucidsoft]

I think it may make sense to include this in the .NET 6 branch since that's also a breaking change. Thoughts?

[GuyWhoKnowsTheGuy]

Agreed, these changes have been put in the .NET 6 branch.