search

elucidsoft / dotnet-stellar-sdk

Stellar API SDK for .NET 6.x
Apache License 2.0
117 stars 54 forks source link

Organize SEPs with New Folder Structure and Implement SEP-1 and SEP-24 #391

Open ydag opened 1 year ago

ydag commented 1 year ago

This issue proposes reorganizing the existing SEP-10 implementation in the dotnet-stellar-sdk and adding support for SEP-24. The current SDK already includes support for SEP-10, but it could benefit from a more structured folder system, making it easier to maintain and expand with additional SEPs.

To better organize the implementation of SEPs, I suggest creating a folder structure that separates each SEP into its own directory, similar to the organization of the stellar-flutter-sdk. This would involve moving the existing SEP-10 implementation into the proposed folder structure and then implementing SEP-1 and SEP-24 alongside it.

The proposed folder structure is as follows:

dotnet-stellar-sdk
│
└───sep
    ├───0001
    ├───0010
    └───0024

By implementing this change, we can achieve the following goals:

1- Improve the maintainability and organization of the dotnet-stellar-sdk. 2- Make it easier for developers to find and utilize the SEP implementations they need. 3- Set a precedent for adding support for more SEPs in the future.

This proposal aims to implement SEP-1, SEP-24 and restructure the existing SEP-10 implementation to fit the proposed folder structure.

elucidsoft commented 1 year ago

Ok, this makes sense to me.

ydag commented 1 year ago

Great! I will send the PR.