search

elueckel / Unifi-Toolbox

Modul for Symcon integrating UniFi Network devices
2 stars 2 forks source link

Merging testing with new features with beta #22

Closed elueckel closed 2 years ago

elueckel commented 2 years ago

Die Echos habe ich eingebaut damit man in die Condole einen Fehler bekommt. Ich kann leider keinen besseren Weg für Feedback.

Am 30.12.2021 um 19:26 schrieb Brovning @.***>:

 @Brovning commented on this pull request.

In UniFi Device Blocker/module.php:

@@ -148,9 +148,13 @@ public function AuthenticateAndProcessRequest() { } else if ($code == 400) { $this->SendDebug($this->Translate("Authentication"),$this->Translate('400 Bad Request - The server cannot or will not process the request due to an apparent client error.'),0);

  • echo $this->Translate('400 Bad Request - The server cannot or will not process the request due to an apparent client error.'); @elueckel Ist es beabsichtigt die "echo"-Ausgaben im Code zu belassen?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

elueckel commented 2 years ago

Gerne einfügen wenn es besser ist.

Am 30.12.2021 um 19:29 schrieb Brovning @.***>:

 @Brovning commented on this pull request.

In UniFi Device Blocker/module.php:

@@ -148,9 +148,13 @@ public function AuthenticateAndProcessRequest() { } else if ($code == 400) { $this->SendDebug($this->Translate("Authentication"),$this->Translate('400 Bad Request - The server cannot or will not process the request due to an apparent client error.'),0);

  • echo $this->Translate('400 Bad Request - The server cannot or will not process the request due to an apparent client error.');
  • exit(); @elueckel Da wir uns in einer Funktion befinden, wäre folgendes zu bevorzugen: return false;

Und am Ende im Idealfall noch für die erfolgreiche Ausführung: return true;

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.