search

elunico / custom-youtube-speed

An extension for setting a custom playback speed in YouTube videos
MIT License
14 stars 4 forks source link

Shortcut keys for adjusting speed by 0.1x are changing speed by 0.2x instead #20

Closed Sir-Billiam closed 11 months ago

Sir-Billiam commented 1 year ago

Recently, I have been having an issue where when I press my shortcut keys to speed up or slow down a video by 0.1x, it will instead adjust it in increments of 0.2x instead. I am using Chrome version 117.0.5938.150, and the issue seems to most often appear if I pause a video, put my PC to sleep (Windows 10 Pro 22H2), and then wake the PC and start watching again. It resolves if I refresh the page, but that sometimes causes videos to lose my placement in the timeline and completely restart. If you need any more information from me, or know how to fix this, please let me know! Thank you

elunico commented 1 year ago

Hi! First of all thank you for provide so much platform specific information. I have been meaning to make an issue template to get more data from people who submit bugs, but since I really only created this extension for fun, I haven't had time to do that.

If you have a general idea of when this started happening that would be helpful. Is it as recent as like yesterday or maybe this week or as recent as like sometime in the last month?

It would also be helpful to know if the part about putting the computer to sleep is necessary? Does pausing on its own not cause this bug?

Thank you for reporting this issue 😊

WTFrankly commented 1 year ago

same issue since the extension updated a few days ago

elunico commented 1 year ago

Can you tell me anything about your platform @WTFrankly ? Are you also using Windows 10 and that version of Chrome. I have not been able to reproduce this problem myself but I am using Chrome 117.0.5938.149 on macOS

WTFrankly commented 1 year ago

@elunico yes sorry, I am using System:Windows 10 64-bit Chromium version:116.0.5845.180 opera gx browser

Sir-Billiam commented 1 year ago

Sorry for missing this. It happened after what I assume is the last update. I also have noticed that it happens when waking the computer from sleep and then opening chrome (meaning chrome was not running when sleep was started), and if the computer goes idle and turns the screen off but the pc stays on while chrome is open. Pausing on its own does not cause the bug in my experience, as long as the computer is actively in use.

On Thu, Oct 5, 2023 at 8:37 AM Tom @.***> wrote:

Hi! First of all thank you for provide so much platform specific information. I have been meaning to make an issue template to get more data from people who submit bugs, but since I really only created this extension for fun, I haven't had time to do that.

If you have a general idea of when this started happening that would be helpful. Is it as recent as like yesterday or maybe this week or as recent as like sometime in the last month?

It would also be helpful to know if the part about putting the computer to sleep is necessary? Does pausing on its own not cause this bug?

Thank you for reporting this issue 😊

— Reply to this email directly, view it on GitHub https://github.com/elunico/custom-youtube-speed/issues/20#issuecomment-1748918826, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5TTD2XCATHJK7LZSZFTBITX52Z2PAVCNFSM6AAAAAA5TO5B4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYHEYTQOBSGY . You are receiving this because you authored the thread.Message ID: @.***>

shalva97 commented 1 year ago

I can also confirm. Shortcuts used to speed up video are multiplied by 2. Currently on Firefox 118.0.1

elunico commented 1 year ago

Thank you everyone for providing the information regarding this issue.

I am actively working to solve it, but I do not encounter the issue very frequently and I am unsure why it only happens intermittently. I am looking through the new code and the Chrome and Firefox developer documentation to see if I'm doing something that could cause this with the way I wrote the code.

If I cannot solve this issue I might consider rolling back to the previous version until I can and putting a note on #18 It will depend on how it's affecting the usage of the extension.

For now I will leave the extension as it is and continue to try to find the cause this week. If anyone has any more insight that they would like contribute I would appreciate it, but I want to say thanks again for bringing this to my attention.

Sir-Billiam commented 1 year ago

Is there a way we can manually roll back our versions? This bug is kind of frustrating to deal with, especially since I use the extension to speed up podcasts and other very long videos I put on in the background to listen to. Thank you

On Sun, Oct 15, 2023 at 10:23 AM Tom @.***> wrote:

Thank you everyone for providing the information regarding this issue.

I am actively working to solve it, but I do not encounter the issue very frequently and I am unsure why it only happens intermittently. I am looking through the new code and the Chrome and Firefox developer documentation to see if I'm doing something that could cause this with the way I wrote the code.

If I cannot solve this issue I might consider rolling back to the previous version until I can and putting a note on #18 https://github.com/elunico/custom-youtube-speed/issues/18 It will depend on how it's affecting the usage of the extension.

For now I will leave the extension as it is and continue to try to find the cause this week. If anyone has any more insight that they would like contribute I would appreciate it, but I want to say thanks again for bringing this to my attention.

— Reply to this email directly, view it on GitHub https://github.com/elunico/custom-youtube-speed/issues/20#issuecomment-1763422997, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5TTD2S345XAUNDSPDUKWOLX7P5XBANCNFSM6AAAAAA5TO5B4U . You are receiving this because you authored the thread.Message ID: @.***>

elunico commented 1 year ago

Since I cannot seem to reproduce the bug, and the new music change was pretty fragile to begin with, I have decided to roll back to the previous published version. It will take Google up to a few days to approve the extension.

Unfortunately, Google provides no way for either the user or developer to rollback their extension versions, so I will have to resubmit a version 10.0.0 without the music check.

Firefox does allow rollback, and I have already done so with Mozilla.

Thank you for your contributions, if I can find the source of the problem I will reintroduce the feature without this bug

elunico commented 1 year ago

Looks like Chrome released the extension super quickly 10.0.0 is the rollback version and its up on the web store.

elunico commented 1 year ago

Opened the issue in case anyone has a comment. I didn't even realize that closing it would close comments