elunna / hackem

SlashEM forked Unto Evil with a Splice of X and a dash of THEM.
Other
23 stars 8 forks source link

Marauder's Map vanishes when invoke reveals no magic items #527

Closed Ardub23 closed 11 months ago

Ardub23 commented 11 months ago

2023-12-02.05_25_59.ttyrec.gz In this ttyrec, around frame 19700 (29m48s), I invoked the Marauder's Map and got these messages:

Ye detect the absence o' artifacts. Ye feel mundane.

Afterward, the Marauder's Map is gone. I'd gotten the "absence o' artifacts" message before, but this was the first time feeling "mundane" when invoking the map.

Looking at the source code, this seems to be due to the fact that magic_detect in detect.c passes the detector to strange_feeling for the "feel mundane" message, and strange_feeling uses up the object unconditionally.

elunna commented 11 months ago

Ooh that is not good. Thank you for reporting and spending the extra time to figure out why!