search

elupus / hass_nibe

Home Assistant Nibe Uplink Integration
185 stars 54 forks source link

Integration into HA core? #134

Closed MatthiasLohr closed 6 months ago

MatthiasLohr commented 2 years ago

Hi,

I tried to check for similar tickets but couldn't find one, therefore here my question: Is there any specific reason why you don't want to add this integration to HA core?

I'm a HA contributor myself, highly interested in getting this integration into HA core, so if you agree, we could work together on getting your work into HA core. What do you think about that?

Best regards Matthias

elupus commented 2 years ago

Just not been too find of the review experience :). Also i don't like some of my own design solutions for how it initializes (delays ha startup). That needs to be resolved before it can be mainlined.

Secondly it will need to ve mainlined in pieces since a big bang won't be accepted. That said, it would be nice to get it in.

MatthiasLohr commented 2 years ago

So, then, with your permission, I would take your code and prepare something towards a first pull request to HA core. I already have one successful integration built up from scratch and got accepted to HA core, so why not do another one :) If you're interested, we can also do some call and you could explain what you mean with design decisions.

elupus commented 2 years ago

Go for it!

elupus commented 2 years ago

Ps. I might even end up reviewing my own code ;)

MatthiasLohr commented 2 years ago

Meeh. Just discovered: My new NIBE devices are using the new myUplink API. This raises the question: Should we try to combine it all in one python library (by extending your nibeuplink package) and HA integration, or should that be done in seperate integrations/libraries?

Chrille144 commented 2 years ago

Hey,

Has there been any progress in getting this integration in Core? Any timeline?

Thanks for all the hard work! /C

elupus commented 2 years ago

Nope.

elupus commented 6 months ago

This will never be merged to core since it's being deprecated by nibe. There is a new myuplink in core for those that have had their pumps upgraded.