elusive / diagrammable

Diagramming editor and viewer for mermaid text based diagrams.
0 stars 0 forks source link

Fix issues with linux build target. #25

Closed elusive closed 1 year ago

elusive commented 1 year ago

When building a package for linux there is an error. Consequently the build action for linux on github does not work either.

Current error can be seen in the following stack trace: ⨯ unknown output format set github.com/develar/app-builder/pkg/icons.convertSingleFile /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:305 github.com/develar/app-builder/pkg/icons.doConvertIcon /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:247 github.com/develar/app-builder/pkg/icons.ConvertIcon /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:56 github.com/develar/app-builder/pkg/icons.ConfigureCommand.func1 /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:33 github.com/alecthomas/kingpin.(*actionMixin).applyActions /Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/actions.go:28 github.com/alecthomas/kingpin.(*Application).applyActions /Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:557 github.com/alecthomas/kingpin.(*Application).execute /Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:390 github.com/alecthomas/kingpin.(*Application).Parse /Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:222 main.main /Volumes/data/Documents/app-builder/main.go:90 runtime.main /usr/local/Cellar/go/1.16.5/libexec/src/runtime/proc.go:225 runtime.goexit /usr/local/Cellar/go/1.16.5/libexec/src/runtime/asm_amd64.s:1371 ⨯ /home/jogi/source/github.com/elusive/diagrammable/node_modules/app-builder-bin/linux/x64/app-builder exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE failedTask=build stackTrace=Error: /home/jogi/source/github.com/elusive/diagrammable/node_modules/app-builder-bin/linux/x64/app-builder exited with code ERR_ELECTRON_BUILDER_CANNOT_EXECUTE at ChildProcess.<anonymous> (/home/jogi/source/github.com/elusive/diagrammable/node_modules/builder-util/src/util.ts:250:14) at Object.onceWrapper (node:events:628:26) at ChildProcess.emit (node:events:513:28) at maybeClose (node:internal/child_process:1100:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

elusive commented 1 year ago

Error is due to the use of an ico file type for the icon instead of something like png. See reference here: https://github.com/electron-userland/electron-builder/issues/4938