eluv-io / elv-fabric-browser

Eluvio Content Fabric Browser
MIT License
2 stars 1 forks source link

Add ability to copy a content object #20

Closed elv-zenia closed 3 years ago

elv-zenia commented 3 years ago

Allow user to copy a content object. See associated client-js PR: https://github.com/eluv-io/elv-client-js/pull/128. The content browser modal is identical to the one used by live-manager.

Main test cases:

image

https://user-images.githubusercontent.com/91760982/141022944-f78c82f0-ac70-4639-bdb7-8e8b7ffb2b39.mov

https://user-images.githubusercontent.com/91760982/141022953-f1bc7718-340a-4943-9561-c5364251ce72.mov

Relates to #8

Future improvements:

elv-zenia commented 3 years ago

@elv-kevin Can you review? I think including fields to edit (like name) needs some extra work. Like maybe a multi-step modal. Also, looks like copying to a different library works as well.

elv-kevin commented 3 years ago

one last nitpick before I merge it - hitting cancel on the confirmation shouldn't close the whole thing, just the modal. I think all you need to do is move Close() into the onConfirm function instead of unconditionally after the confirm.