search

elvanja / jenkins-gitlab-hook-plugin

Enables Gitlab web hooks to be used to trigger SMC polling on Gitlab projects
142 stars 81 forks source link

Payload params #31

Closed xaniasd closed 10 years ago

xaniasd commented 10 years ago

This is a basic way to provide payload data as parameters to the build. In this case the repository_id is added to the build. Comes together with a couple of tests.

elvanja commented 10 years ago

Nice work, thanks! There are a few minor things to resolve, see the comments. Let's fix that and I'll merge.

xaniasd commented 10 years ago

Done!

elvanja commented 10 years ago

Cool, just noticed one more thing. parse_request_spec.rb references default_payload.json while you added the push_payload.json. It would be better to just update the default one with push data (and remove push payload) and make sure all specs are passing. That way we'd have default and merge payload, which seems OK.

xaniasd commented 10 years ago

..aaand done, All specs are passing.