Implement global descriptor

elvanja / jenkins-gitlab-hook-plugin

Enables Gitlab web hooks to be used to trigger SMC polling on Gitlab projects

142 stars 81 forks source link

Implement global descriptor #44

Closed javiplx closed 10 years ago

javiplx commented 10 years ago

Added global configuration for the plugin, as well as minimal help files for the UI.

NOTE : this PR is not merged cleanly with #41, and probably neither with #42. If you agree with them, I can easily do a single PR with all the changes and no conflict.

elvanja commented 10 years ago

Merged into master. I've synced this with other changes from $41 and #42. Didn't change much from original, just some styling and added support for settings module, in specs and main code as well. The configuration is saved as expected. Need to test the behavior some more. Thanks for the work done!

javiplx commented 10 years ago

Changes are enough as not allowing merging with/towards the work I'm doing on branch feature/templated_jobs. I believe main reason is the indentation fix from b51cd0eedc89cf9513349b33a92c8788089397ec, but also contribution from d9ab46e18a5172ad2d8abe0d912b4fa326198de0. I'll continue working in parallel, and postpone resolution until the time for the PR arrives.