elves / elvish

Powerful scripting language & versatile interactive shell
https://elv.sh/
BSD 2-Clause "Simplified" License
5.53k stars 297 forks source link

Implement `os:chmod` #1730

Closed krader1961 closed 6 months ago

krader1961 commented 8 months ago

Related: #1659

krader1961 commented 8 months ago

There are other uses of generic errors that, arguably, should use the errs.Generic this change introduces. Such as ttySetupErr in TestReadCode_AbortsWhenTTYSetupReturnsError (pkg/cli/app_test.go). I considered those cases too far outside the scope of this change.

xiaq commented 6 months ago

Thanks for the contribution. My thoughts:

Thanks again for the contribution but I won't be merging this PR; I have prepared my implementation that I will push shortly.