elves / elvish

Powerful scripting language & versatile interactive shell
https://elv.sh/
BSD 2-Clause "Simplified" License
5.53k stars 297 forks source link

Regression: the Down key now reports "Unbound key: Down" #1738

Closed krader1961 closed 6 months ago

krader1961 commented 6 months ago

Commit 6f47909c, merged 2017-02-11, introduced a regression. Prior to that commit pressing the Down key when at the end of the command history would output "End of history" (that message was introduced by commit 0dc0fce merged 2016-04-06). After that commit nothing is output. At least until commit 4187d41da, merged 2023-03-03, which causes "Unbound key: Down" to be output. The new "Unbound key: Down" message caused an Elvish user to wonder if there was a problem with their Elvish installation.

krader1961 commented 6 months ago

Sigh! My previous diagnosis was wrong because I didn't account for other major changes to the source since commit https://github.com/elves/elvish/commit/6f47909c20cc027ae0c586cfafd6f51c64c5f2a9 that invalidated my initial search. It appears the actual regression was introduced by commit 837f124f1, merged 2018-01-03, that moved the default bindings from hardcoded Go code to an embedded Elvish script. Specifically file eval/bundled/binding.elv.go introduced by that commit.