Closed krader1961 closed 8 months ago
While this issue probably only affects me this bug means that any testing I do locally will fail on my FreeBSD VM. Which is slightly annoying but I can deal with that for the immediate future. Long term either my unit test workaround needs to be introduced or a proper fix to accommodate the FreeBSD quirk causing the failure needs to be introduced.
JFC! This https://github.com/golang/go/issues/19596 describes the reason the Elvish os:chmod
unit test fails on FreeBSD. I have confirmed that the directory created by the unit test is owned by group wheel
while my account is not in that group. TBD is how to deal with this while still allowing testing the setgid behavior.
Commit cf9ec15fa68e02799190582e539c338d4f9a4a55 added an
os:chmod
command modeled on my change that was rejected. The problem is that the replacement for my change fails on FreeBSD:My change explicitly special-cased FreeBSD in the
TestChmod
unit test:That special-case is probably wrong since it papers over what might be a serious problem. Nonetheless, it allowed the unit tests to pass on all supported platforms, including FreeBSD, while the current master branch fails. Either my unit test special-case for FreeBSD should be added or a proper fix introduced for this behavior on FreeBSD.